Skip to content

feat: keep "other" bodies when performing bool operations#1311

Merged
RobPasMue merged 3 commits into
mainfrom
feat/keep-other-bodies-on-bool-operations
Jul 16, 2024
Merged

feat: keep "other" bodies when performing bool operations#1311
RobPasMue merged 3 commits into
mainfrom
feat/keep-other-bodies-on-bool-operations

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

Provide the option to keep the "other" bodies passed when performing a bool operation. By default it will be false to support backward compatibility.

Issue linked

Closes #1302

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jul 16, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner July 16, 2024 08:17
@github-actions github-actions Bot added the enhancement New features or code improvements label Jul 16, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (7847aea) to head (cb4fb20).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1311   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          85       85           
  Lines        6600     6602    +2     
=======================================
+ Hits         6077     6079    +2     
  Misses        523      523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 1df9f11 into main Jul 16, 2024
@RobPasMue RobPasMue deleted the feat/keep-other-bodies-on-bool-operations branch July 16, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce Argument to Retain Subtracted Body in Subtract Function

2 participants