Skip to content

chore: adding issue links to TODOs#1320

Merged
RobPasMue merged 4 commits into
mainfrom
maint/todos-properly-linked
Jul 19, 2024
Merged

chore: adding issue links to TODOs#1320
RobPasMue merged 4 commits into
mainfrom
maint/todos-properly-linked

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

As title says - related to #1319

Issue linked

Related to #1319

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jul 19, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner July 19, 2024 10:54
@github-actions github-actions Bot added maintenance Package and maintenance related testing Anything related to tests labels Jul 19, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.03%. Comparing base (6af4805) to head (4f5a5da).

Files Patch % Lines
src/ansys/geometry/core/designer/design.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1320   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          86       86           
  Lines        6713     6713           
=======================================
  Hits         6178     6178           
  Misses        535      535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 7f92649 into main Jul 19, 2024
@RobPasMue RobPasMue deleted the maint/todos-properly-linked branch July 19, 2024 11:45
@MaxJPRey
Copy link
Copy Markdown
Contributor

Thanks @RobPasMue for tackling that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants