Skip to content

feat: adapt to new ansys-tools-visualization-interface v0.4.0#1338

Merged
RobPasMue merged 2 commits intomainfrom
docs/multi-colors-example
Aug 1, 2024
Merged

feat: adapt to new ansys-tools-visualization-interface v0.4.0#1338
RobPasMue merged 2 commits intomainfrom
docs/multi-colors-example

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

Using v0.4.0 for the viz tool - especially on doc build since it was causing interactive docs not to render. Also included example for multi_colors. Example had to be left static since there is some issue when using multi_colors on doc build... 😢

Issue linked

ansys/ansys-tools-visualization-interface#117

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Aug 1, 2024
@RobPasMue RobPasMue requested review from a team and PipKat as code owners August 1, 2024 08:31
@RobPasMue RobPasMue changed the title feat: adapt to new ansys-tools-visualization-interface feat: adapt to new ansys-tools-visualization-interface v0.4.0 Aug 1, 2024
@github-actions github-actions bot added maintenance Package and maintenance related documentation Improvements or additions to documentation labels Aug 1, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Aug 1, 2024
@RobPasMue RobPasMue enabled auto-merge (squash) August 1, 2024 08:49
@RobPasMue RobPasMue disabled auto-merge August 1, 2024 08:49
Copy link
Copy Markdown
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobPasMue RobPasMue enabled auto-merge (squash) August 1, 2024 08:49
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (3dfe1c3) to head (c4a64bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1338   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          86       86           
  Lines        6754     6754           
=======================================
  Hits         6209     6209           
  Misses        545      545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 8321970 into main Aug 1, 2024
@RobPasMue RobPasMue deleted the docs/multi-colors-example branch August 1, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants