Skip to content

chore: solving various warnings - #1368

Merged
RobPasMue merged 2 commits into
mainfrom
maint/fix-warnings
Aug 23, 2024
Merged

chore: solving various warnings#1368
RobPasMue merged 2 commits into
mainfrom
maint/fix-warnings

Conversation

@RobPasMue

Copy link
Copy Markdown
Member

Description

As title says - tests were raising several warnings.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Aug 23, 2024
@RobPasMue
RobPasMue marked this pull request as ready for review August 23, 2024 13:31
@RobPasMue
RobPasMue requested a review from a team as a code owner August 23, 2024 13:31
@github-actions github-actions Bot added the maintenance Package and maintenance related label Aug 23, 2024
@github-actions github-actions Bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Aug 23, 2024
@codecov

codecov Bot commented Aug 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (aa54721) to head (213ec90).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1368   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          86       86           
  Lines        6737     6739    +2     
=======================================
+ Hits         6193     6195    +2     
  Misses        544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue
RobPasMue merged commit a397f63 into main Aug 23, 2024
@RobPasMue
RobPasMue deleted the maint/fix-warnings branch August 23, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants