Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1375 +/- ##
=======================================
Coverage 91.86% 91.87%
=======================================
Files 86 86
Lines 6788 6790 +2
=======================================
+ Hits 6236 6238 +2
Misses 552 552 ☔ View full report in Codecov by Sentry. |
AlejandroFernandezLuces
previously approved these changes
Aug 27, 2024
Contributor
AlejandroFernandezLuces
left a comment
There was a problem hiding this comment.
LGTM, minor comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have the
modeler.close()method but in order to be in line with the other PyAnsys libraries, we are also includingmodeler.exit()now. They will effectively perform the same calls.Issue linked
Related to #1374
Checklist
feat: extrude circle to cylinder)