Skip to content

feat: add modeler.exit() method#1375

Merged
RobPasMue merged 6 commits intomainfrom
feat/add-exit-method
Aug 27, 2024
Merged

feat: add modeler.exit() method#1375
RobPasMue merged 6 commits intomainfrom
feat/add-exit-method

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

We have the modeler.close() method but in order to be in line with the other PyAnsys libraries, we are also including modeler.exit() now. They will effectively perform the same calls.

Issue linked

Related to #1374

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Aug 27, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner August 27, 2024 12:17
@github-actions github-actions bot added the enhancement New features or code improvements label Aug 27, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (0c1f9b8) to head (634fbae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1375   +/-   ##
=======================================
  Coverage   91.86%   91.87%           
=======================================
  Files          86       86           
  Lines        6788     6790    +2     
=======================================
+ Hits         6236     6238    +2     
  Misses        552      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment.

Comment thread src/ansys/geometry/core/modeler.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants