feat: use service colors in plotter (upon request)#1376
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1376 +/- ##
==========================================
- Coverage 91.81% 91.79% -0.02%
==========================================
Files 86 86
Lines 6880 6912 +32
==========================================
+ Hits 6317 6345 +28
- Misses 563 567 +4 ☔ View full report in Codecov by Sentry. |
…ansys/pyansys-geometry into feat/use-body-colors-in-plotter
Member
Author
|
Hi @PipKat - would you be able to review at least the |
Member
Author
|
This PR is expected to fail certain tests (at least until the new server version is available with the "null" return for colors whenever it is not assigned. |
Member
Author
|
I can't believe we are about to close this 😍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabling the usage of service colors upon request. Including a new library global variable called
ansys.geometry.core.USE_SERVICE_COLORS. If set toTruethe plotter will make use of the service-defined colors. This can make large components to be plotted very slowly since it will require interaction with the service. By default, SC green will be used, just like until now.We are also exposing these capabilities now via the
plot(...)methods. Users won't have to specifically set the global variable if they just want to check it once.Documentation and testing has been added.
Issue linked
Closes #433
Checklist
feat: extrude circle to cylinder)