feat: setting instance name during component creation by umutsoysalansys · Pull Request #1382 · ansys/pyansys-geometry

umutsoysalansys · 2024-08-28T12:57:22Z

Description

**This change enables users to set the instance name (optional) while creating a component. **

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

I have tested my changes locally.
I have added necessary documentation or updated existing documentation.
I have followed the coding style guidelines of this project.
I have added appropriate unit tests.
I have reviewed my changes before submitting this pull request.
I have linked the issue or issues that are solved to the PR if any.
I have assigned this PR to myself.
I have added the minimum version decorator to any new backend method implemented.
I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

codecov · 2024-08-28T13:10:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (e46854e) to head (ad711b2).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1382   +/-   ##
=======================================
  Coverage   91.79%   91.80%           
=======================================
  Files          86       86           
  Lines        6824     6831    +7     
=======================================
+ Hits         6264     6271    +7     
  Misses        560      560

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

umutsoysalansys · 2024-09-02T23:31:22Z

@b-matteo @RobPasMue ready for review:)

RobPasMue

Several cleanup comments and improvements. Also, @umutsoysalansys - have you checked with @rajesh1359 or @agvarghe that this is what they were expecting? I'm not sure where the request for this is coming from

RobPasMue · 2024-09-03T10:27:06Z

Please update your branch with respect to main as well.

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

RobPasMue

If you are resolving comments, make sure you are either answering them or committing my suggestions. Do not just close them @umutsoysalansys

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

RobPasMue · 2024-09-04T08:28:56Z

Windows new version is working. Linux version is having issues. @b-matteo investigating.

…ys/pyansys-geometry into feat/component_instance_name

umutsoysalansys · 2024-09-05T15:02:34Z

@RobPasMue, updated API Server, linux tests are passing. What is this testing with minimum requirement workflow? @b-matteo How to test locally?

umutsoysalansys · 2024-09-05T15:06:59Z

@RobPasMue pls review and approve thanks.

RobPasMue · 2024-09-05T15:07:47Z

@RobPasMue, updated API Server, linux tests are passing. What is this testing with minimum requirement workflow? @b-matteo How to test locally?

Minimum requirement workflow just tries to install the project without the "test-pinned" dependencies. It runs on all supported Python versions, but it also uses the linux-latest image. Since we have not pushed the unstable ones to stable yet, the tests related to the instance_name. Don't worry @umutsoysalansys - once we push the images to stable, the checks will pass.

umutsoysalansys · 2024-09-05T15:09:09Z

[like] Umut Soysal reacted to your message:

…

________________________________ From: Roberto Pastor Muela ***@***.***> Sent: Thursday, September 5, 2024 3:08:10 PM To: ansys/pyansys-geometry ***@***.***> Cc: Umut Soysal ***@***.***>; Mention ***@***.***> Subject: Re: [ansys/pyansys-geometry] feat: setting instance name during component creation (PR #1382) [External Sender] @RobPasMue<https://github.com/RobPasMue>, updated API Server, linux tests are passing. What is this testing with minimum requirement workflow? @b-matteo<https://github.com/b-matteo> How to test locally? Minimum requirement workflow just tries to install the project without the "test-pinned" dependencies. It runs on all supported Python versions, but it also uses the linux-latest image. Since we have not pushed the unstable ones to stable yet, the tests related to the instance_name. Don't worry @umutsoysalansys<https://github.com/umutsoysalansys> - once we push the images to stable, the checks will pass. — Reply to this email directly, view it on GitHub<#1382 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXFRLERG3H7RLMKK35WI47TZVBXVVAVCNFSM6AAAAABNIHPT3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZRHE3DKNZVGQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

RobPasMue · 2024-09-05T15:10:37Z

@RobPasMue pls review and approve thanks.

You are not the only one wanting to finish this PR @umutsoysalansys - we are all waiting for things to work properly and pass in the workflow. Until then, we cannot merge. You can assume it's approved anyway.

umutsoysalansys · 2024-09-05T15:12:18Z

what is holding it back? Unstable images are passing? @RobPasMue

RobPasMue · 2024-09-05T15:14:37Z

what is holding it back? Unstable images are passing? @RobPasMue

Linux latest unstable image is updated. ADO is still pushing the Windows image.

umutsoysalansys · 2024-09-05T15:20:49Z

what is holding it back? Unstable images are passing? @RobPasMue

Linux latest unstable image is updated. ADO is still pushing the Windows image.

Ready to approve and merge @RobPasMue

umutsoysalansys · 2024-09-05T16:29:24Z

maybe we need an reviewer/approver in US time zone. so we can move faster.

RobPasMue · 2024-09-05T16:58:40Z

@umutsoysalansys please stop, we have already heard you

RobPasMue

LGTM - merging

component name

e7fb641

github-actions bot added the enhancement New features or code improvements label Aug 28, 2024

chore: adding changelog file 1382.added.md

5e38956

Merge branch 'main' into feat/component_instance_name

6f945f2

RobPasMue assigned umutsoysalansys Aug 29, 2024

umutsoysalansys added 2 commits August 30, 2024 09:40

update

a9feed8

unit tests fix

7249b9b

umutsoysalansys marked this pull request as ready for review September 2, 2024 13:19

umutsoysalansys requested a review from a team as a code owner September 2, 2024 13:19

umutsoysalansys assigned RobPasMue, smereu and b-matteo Sep 2, 2024

RobPasMue requested changes Sep 3, 2024

View reviewed changes

umutsoysalansys requested review from b-matteo and smereu September 3, 2024 13:26

umutsoysalansys assigned umutsoysalansys and unassigned RobPasMue, smereu, b-matteo and umutsoysalansys Sep 3, 2024

umutsoysalansys and others added 7 commits September 3, 2024 08:28

Update src/ansys/geometry/core/designer/component.py

33c564d

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Update src/ansys/geometry/core/designer/component.py

1f969b8

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Update src/ansys/geometry/core/designer/component.py

41f69e7

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Update tests/integration/test_design.py

ed7dda8

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Update tests/integration/test_design.py

89c25b7

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

typos

0f72375

Merge branch 'main' into feat/component_instance_name

2f8b908

RobPasMue requested changes Sep 3, 2024

View reviewed changes

Comment thread src/ansys/geometry/core/designer/component.py

RobPasMue and others added 3 commits September 3, 2024 16:09

Update src/ansys/geometry/core/designer/component.py

de1cc6c

Merge branch 'main' into feat/component_instance_name

e0101e6

Update src/ansys/geometry/core/designer/component.py

65834eb

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

RobPasMue reviewed Sep 4, 2024

View reviewed changes

Comment thread src/ansys/geometry/core/designer/component.py Outdated

RobPasMue and others added 3 commits September 4, 2024 08:23

Update src/ansys/geometry/core/designer/component.py

ef0e66a

fix: align behavior

212eac6

chore: auto fixes from pre-commit hooks

cef6c57

umutsoysalansys commented Sep 4, 2024

View reviewed changes

Comment thread tests/integration/test_design.py Outdated

umutsoysalansys commented Sep 4, 2024

View reviewed changes

Comment thread src/ansys/geometry/core/designer/component.py

RobPasMue added 3 commits September 4, 2024 17:08

ci: improve testing (double check name as well)

de31f46

Merge branch 'feat/component_instance_name' of https://github.com/ans…

1d16826

…ys/pyansys-geometry into feat/component_instance_name

Merge branch 'main' into feat/component_instance_name

6f92a49

umutsoysalansys commented Sep 4, 2024

View reviewed changes

Comment thread tests/integration/test_design.py

umutsoysalansys requested a review from RobPasMue September 5, 2024 15:01

Merge branch 'main' into feat/component_instance_name

ad711b2

RobPasMue approved these changes Sep 5, 2024

View reviewed changes

RobPasMue merged commit 7039aea into main Sep 5, 2024

RobPasMue deleted the feat/component_instance_name branch September 5, 2024 17:26

Conversation

umutsoysalansys commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue linked

Checklist

Uh oh!

codecov bot commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

umutsoysalansys commented Sep 2, 2024

Uh oh!

RobPasMue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RobPasMue commented Sep 3, 2024

Uh oh!

RobPasMue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RobPasMue commented Sep 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

umutsoysalansys commented Sep 5, 2024

Uh oh!

umutsoysalansys commented Sep 5, 2024

Uh oh!

RobPasMue commented Sep 5, 2024

Uh oh!

umutsoysalansys commented Sep 5, 2024 via email

Uh oh!

RobPasMue commented Sep 5, 2024

Uh oh!

umutsoysalansys commented Sep 5, 2024 • edited by RobPasMue Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RobPasMue commented Sep 5, 2024

Uh oh!

umutsoysalansys commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

umutsoysalansys commented Sep 5, 2024

Uh oh!

RobPasMue commented Sep 5, 2024

Uh oh!

RobPasMue left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

umutsoysalansys commented Aug 28, 2024 •

edited

Loading

codecov bot commented Aug 28, 2024 •

edited

Loading

umutsoysalansys commented Sep 5, 2024 •

edited by RobPasMue

Loading

umutsoysalansys commented Sep 5, 2024 •

edited

Loading