Skip to content

feat: accept pathlib.Path as input in missing methods#1385

Merged
RobPasMue merged 4 commits into
mainfrom
feat/pathlib-path-accepted
Aug 29, 2024
Merged

feat: accept pathlib.Path as input in missing methods#1385
RobPasMue merged 4 commits into
mainfrom
feat/pathlib-path-accepted

Conversation

@RobPasMue

@RobPasMue RobPasMue commented Aug 29, 2024

Copy link
Copy Markdown
Member

Description

As title says - some methods were only accepting strings and not pathlib.Path objects

Issue linked

Related to #1384

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Aug 29, 2024
@github-actions github-actions Bot added the enhancement New features or code improvements label Aug 29, 2024
Comment thread src/ansys/geometry/core/designer/design.py Outdated
Comment thread src/ansys/geometry/core/connection/client.py Outdated
Comment thread src/ansys/geometry/core/modeler.py Outdated
Comment thread src/ansys/geometry/core/modeler.py Outdated
@codecov

codecov Bot commented Aug 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (8af9de9) to head (88a908a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1385   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          86       86           
  Lines        6790     6792    +2     
=======================================
+ Hits         6238     6240    +2     
  Misses        552      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue marked this pull request as ready for review August 29, 2024 13:47
@RobPasMue RobPasMue requested a review from a team as a code owner August 29, 2024 13:47
@RobPasMue RobPasMue merged commit 1def483 into main Aug 29, 2024
@RobPasMue RobPasMue deleted the feat/pathlib-path-accepted branch August 29, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants