feat: default logs folder on Geometry Service started by Python at PUBLIC (Windows)#1386
Merged
feat: default logs folder on Geometry Service started by Python at PUBLIC (Windows)#1386
Conversation
…cific dir at APPDATA (Windows)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
==========================================
- Coverage 91.87% 91.79% -0.08%
==========================================
Files 86 86
Lines 6792 6802 +10
==========================================
+ Hits 6240 6244 +4
- Misses 552 558 +6 ☔ View full report in Codecov by Sentry. |
MaxJPRey
reviewed
Aug 29, 2024
Member
Author
Well.. That's a good point. We could check whether a user has write access to the folder even before starting (in case it is provided). And if not, we throw an error. Let me check that anyway :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whenever we launch the Geometry Service locally (on Windows), we will make use of the APPDATA directory for Ansys products. Users should always have write permissions to it, and it will prevent from having some common issues like #1374 (reply in thread)
Issue linked
Closes #1377
Checklist
feat: extrude circle to cylinder)