fix: remove server_logs_folder argument for Discovery and SpaceClaim#1387
Merged
RobPasMue merged 2 commits intoSep 2, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1387 +/- ##
==========================================
- Coverage 91.79% 91.77% -0.03%
==========================================
Files 86 86
Lines 6802 6806 +4
==========================================
+ Hits 6244 6246 +2
- Misses 558 560 +2 ☔ View full report in Codecov by Sentry. |
RobPasMue
deleted the
fix/remove-server-logs-folder-from-scdm-and-disco
branch
September 2, 2024 07:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After conversations with @b-matteo - environment variable
ANS_DSCO_REMOTE_LOGS_FOLDERis only applicable for the Geometry Service. Removing it as a potential input for SpaceClaim and DiscoveryIssue linked
None - but related to #1377
Checklist
feat: extrude circle to cylinder)