Skip to content

feat: allowing users to specify API version when running script against SpaceClaim or Discovery#1395

Merged
RobPasMue merged 18 commits intomainfrom
feat/api-version-specifier-in-open-file
Sep 3, 2024
Merged

feat: allowing users to specify API version when running script against SpaceClaim or Discovery#1395
RobPasMue merged 18 commits intomainfrom
feat/api-version-specifier-in-open-file

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

Allownig API version input as part of the script execution (i.e. run_discovery_script_file(...) method. Input is accepted as a pure integer, ApiVersions enum or string. The GeometryService will ignore any input given and just throw a warning on the log.

Issue linked

Related to #1389

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Sep 3, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner September 3, 2024 11:09
@github-actions github-actions bot added testing Anything related to tests enhancement New features or code improvements labels Sep 3, 2024
Comment thread src/ansys/geometry/core/modeler.py Outdated
Comment thread src/ansys/geometry/core/modeler.py Outdated
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (4869d60) to head (a800618).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
+ Coverage   91.77%   91.79%   +0.01%     
==========================================
  Files          86       86              
  Lines        6806     6821      +15     
==========================================
+ Hits         6246     6261      +15     
  Misses        560      560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/ansys/geometry/core/modeler.py Outdated
Comment thread src/ansys/geometry/core/connection/backend.py Outdated
Comment thread src/ansys/geometry/core/connection/backend.py Outdated
Comment thread src/ansys/geometry/core/connection/backend.py Outdated
@RobPasMue RobPasMue merged commit 7430991 into main Sep 3, 2024
@RobPasMue RobPasMue deleted the feat/api-version-specifier-in-open-file branch September 3, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants