Skip to content

feat: pretty print components#1403

Merged
RobPasMue merged 20 commits into
mainfrom
feat/pretty-print-component
Sep 6, 2024
Merged

feat: pretty print components#1403
RobPasMue merged 20 commits into
mainfrom
feat/pretty-print-component

Conversation

@RobPasMue

@RobPasMue RobPasMue commented Sep 4, 2024

Copy link
Copy Markdown
Member

Description

Allowing for tree-style representation of the model

Issue linked

Closes #1402

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Sep 4, 2024
@RobPasMue RobPasMue linked an issue Sep 4, 2024 that may be closed by this pull request
@github-actions github-actions Bot added the enhancement New features or code improvements label Sep 4, 2024
@codecov

codecov Bot commented Sep 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (6b6c3ba) to head (fe1ee4e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
+ Coverage   91.80%   91.85%   +0.05%     
==========================================
  Files          86       86              
  Lines        6831     6873      +42     
==========================================
+ Hits         6271     6313      +42     
  Misses        560      560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue

RobPasMue commented Sep 4, 2024

Copy link
Copy Markdown
Member Author

Looking at something like this right now... Given the comment-described design, when I request design.tree_print() I am getting the following:

image

@RobPasMue

RobPasMue commented Sep 5, 2024

Copy link
Copy Markdown
Member Author

After some enhancements, we decided to add the location and some spacings... When requesting the nested_1_comp_1.tree_print() the output is the following:

image

and requesting comp_1.tree_print() leads to:

image

@RobPasMue RobPasMue marked this pull request as ready for review September 5, 2024 17:35
@RobPasMue RobPasMue requested review from a team and PipKat as code owners September 5, 2024 17:35
Comment thread tests/integration/test_design.py
Comment thread doc/source/examples/03_modeling/design_tree.mystnb Outdated
Comment thread tests/integration/test_design.py Outdated
@RobPasMue RobPasMue merged commit dc0729a into main Sep 6, 2024
@RobPasMue RobPasMue deleted the feat/pretty-print-component branch September 6, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pretty print component tree

2 participants