Skip to content

feat: capability to close designs (also on modeler.exit())#1409

Merged
RobPasMue merged 15 commits into
mainfrom
feat/close-design
Oct 4, 2024
Merged

feat: capability to close designs (also on modeler.exit())#1409
RobPasMue merged 15 commits into
mainfrom
feat/close-design

Conversation

@RobPasMue

@RobPasMue RobPasMue commented Sep 6, 2024

Copy link
Copy Markdown
Member

Description

Allows for closing designs on demand. Experimental feature - only known to work with SpaceClaim and Discovery. Geometry Service may throw back errors but we are ignoring it for now since it is intended to be shortlived.

Issue linked

Closes #1399

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Sep 6, 2024
Comment thread src/ansys/geometry/core/misc/checks.py Outdated
@github-actions github-actions Bot added the enhancement New features or code improvements label Sep 6, 2024
@codecov

codecov Bot commented Sep 6, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (3044faa) to head (38a22e9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/design.py 85.71% 2 Missing ⚠️
src/ansys/geometry/core/misc/checks.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1409      +/-   ##
==========================================
- Coverage   91.84%   91.83%   -0.01%     
==========================================
  Files          86       86              
  Lines        6905     6922      +17     
==========================================
+ Hits         6342     6357      +15     
- Misses        563      565       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue

Copy link
Copy Markdown
Member Author

Core services require proper handling of Design closure... waiting on that.

@RobPasMue
RobPasMue marked this pull request as ready for review October 4, 2024 13:26
@RobPasMue
RobPasMue requested a review from a team as a code owner October 4, 2024 13:26
@RobPasMue
RobPasMue merged commit 402661a into main Oct 4, 2024
@RobPasMue
RobPasMue deleted the feat/close-design branch October 4, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Design object closure and activation using class methods

2 participants