feat: capability to close designs (also on modeler.exit())#1409
Merged
Conversation
RobPasMue
commented
Sep 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
- Coverage 91.84% 91.83% -0.01%
==========================================
Files 86 86
Lines 6905 6922 +17
==========================================
+ Hits 6342 6357 +15
- Misses 563 565 +2 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Core services require proper handling of Design closure... waiting on that. |
RobPasMue
marked this pull request as ready for review
October 4, 2024 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows for closing designs on demand. Experimental feature - only known to work with SpaceClaim and Discovery. Geometry Service may throw back errors but we are ignoring it for now since it is intended to be shortlived.
Issue linked
Closes #1399
Checklist
feat: extrude circle to cylinder)