Skip to content

docs: adapt examples to use launch_modeler instead of Modeler obj connection#1410

Merged
RobPasMue merged 3 commits intomainfrom
docs/adapt-examples-for-ansys-labs
Sep 9, 2024
Merged

docs: adapt examples to use launch_modeler instead of Modeler obj connection#1410
RobPasMue merged 3 commits intomainfrom
docs/adapt-examples-for-ansys-labs

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue commented Sep 6, 2024

Description

Coming from the Ansys Lab team - we should adapt our examples so that they can also be easily consumed on Ansys Lab... and not only that but any user that wants to try them locally! Most of them were assuming that there was a running service in the backend - which is not the usual case.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Sep 6, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 6, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Sep 6, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Sep 6, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (2c80e5f) to head (685f66d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1410   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          86       86           
  Lines        6873     6873           
=======================================
  Hits         6313     6313           
  Misses        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue marked this pull request as ready for review September 9, 2024 07:44
@RobPasMue RobPasMue requested review from a team and PipKat as code owners September 9, 2024 07:44
@RobPasMue RobPasMue merged commit 2d6d8d2 into main Sep 9, 2024
@RobPasMue RobPasMue deleted the docs/adapt-examples-for-ansys-labs branch September 9, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants