Skip to content

feat: allow for platform input when using Ansys Lab#1416

Merged
RobPasMue merged 9 commits intomainfrom
feat/platform-input
Sep 9, 2024
Merged

feat: allow for platform input when using Ansys Lab#1416
RobPasMue merged 9 commits intomainfrom
feat/platform-input

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue commented Sep 9, 2024

Description

Coming from an old request and to make it even more explicit for users.... Users can now benefit from the new "platform" argument when running on Ansys Lab to make it clear they want to use either the "windows" or the "linux" service. This is only available on Ansys Lab for now. If version is passed, this will take precedence since this is the expected argument for PyPIM

Issue linked

Closes #478

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Comment thread src/ansys/geometry/core/connection/launcher.py Outdated
@github-actions github-actions bot added the enhancement New features or code improvements label Sep 9, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (bd57e6f) to head (138729e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1416   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          86       86           
  Lines        6873     6873           
=======================================
  Hits         6313     6313           
  Misses        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue marked this pull request as ready for review September 9, 2024 15:14
@RobPasMue RobPasMue requested a review from a team as a code owner September 9, 2024 15:14
@RobPasMue RobPasMue self-assigned this Sep 9, 2024
Comment thread src/ansys/geometry/core/connection/launcher.py Outdated
Comment thread src/ansys/geometry/core/connection/launcher.py
Comment thread src/ansys/geometry/core/connection/launcher.py Outdated
@RobPasMue RobPasMue merged commit 696b5bd into main Sep 9, 2024
@RobPasMue RobPasMue deleted the feat/platform-input branch September 9, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify version tag referring to service instance to platform type

3 participants