feat: allow for platform input when using Ansys Lab#1416
Merged
Conversation
RobPasMue
commented
Sep 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1416 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 86 86
Lines 6873 6873
=======================================
Hits 6313 6313
Misses 560 560 ☔ View full report in Codecov by Sentry. |
RobPasMue
commented
Sep 9, 2024
MaxJPRey
reviewed
Sep 9, 2024
RobPasMue
commented
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Coming from an old request and to make it even more explicit for users.... Users can now benefit from the new "platform" argument when running on Ansys Lab to make it clear they want to use either the "windows" or the "linux" service. This is only available on Ansys Lab for now. If
versionis passed, this will take precedence since this is the expected argument for PyPIMIssue linked
Closes #478
Checklist
feat: extrude circle to cylinder)