Skip to content

feat: ensure GrpcClient class closure upon deletion#1417

Merged
RobPasMue merged 6 commits intomainfrom
feat/ensure-client-closure
Sep 10, 2024
Merged

feat: ensure GrpcClient class closure upon deletion#1417
RobPasMue merged 6 commits intomainfrom
feat/ensure-client-closure

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

Ensuring the GrpcClient closure method gets called upon completion.

Issue linked

Closes #1415

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue requested a review from a team as a code owner September 9, 2024 15:16
@RobPasMue RobPasMue self-assigned this Sep 9, 2024
@github-actions github-actions bot added the enhancement New features or code improvements label Sep 9, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (9016890) to head (51e9cc2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1417   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          86       86           
  Lines        6873     6875    +2     
=======================================
+ Hits         6313     6315    +2     
  Misses        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/ansys/geometry/core/connection/client.py Outdated
Copy link
Copy Markdown
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobPasMue RobPasMue merged commit e8017a6 into main Sep 10, 2024
@RobPasMue RobPasMue deleted the feat/ensure-client-closure branch September 10, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add server exit to del operator and finished process

3 participants