fix: handle properly np.cross() - 2d ops deprecated in Numpy 2.X#1419
fix: handle properly np.cross() - 2d ops deprecated in Numpy 2.X#1419
np.cross() - 2d ops deprecated in Numpy 2.X#1419Conversation
np.cross() warnings raised - 2d ops deprecated in Numpy 2.Xnp.cross() - 2d ops deprecated in Numpy 2.X
AlejandroFernandezLuces
left a comment
There was a problem hiding this comment.
LGTM, it's wild that we need to do the cross operation that way. I see that they are going to implement a proper operation soon, can we add a TODO or some reminder to change this when np.linalg.cross2d is implemented?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 86 86
Lines 6875 6878 +3
=======================================
+ Hits 6315 6318 +3
Misses 560 560 ☔ View full report in Codecov by Sentry. |
Sure - though I am not sure they will even implement it... they have preferred documenting it over implementing numpy/numpy#26692 and numpy/numpy#26620 (comment) More importantly... see this numpy/numpy#26640 and especially numpy/numpy#26640 (comment) and numpy/numpy#26640 (comment) I don't think it'll ever be implemented honestly... |
Forget about the reminder then 😄 |
Haha! 😄 good then - thanks for pointing it out though! It would've been the way to proceed (if they had decided to eventually implement it... but I think it's not the case - I'll keep an eye on NumPy though and the issues) |
…ansys-geometry into fix/numpy-cross-warning
|
@AlejandroFernandezLuces - I just pushed @MaxJPRey's suggestion to typehint it as well. Can you approve? |
Done @RobPasMue |
Description
As title says - once Numpy 1.X is not used anymore we can remove this.
Issue linked
None
Checklist
feat: extrude circle to cylinder)