Skip to content

feat: prioritize user-defined SPACECLAIM_MODE env var#1440

Merged
RobPasMue merged 5 commits into
mainfrom
feat/allow-for-userdefined-value
Sep 30, 2024
Merged

feat: prioritize user-defined SPACECLAIM_MODE env var#1440
RobPasMue merged 5 commits into
mainfrom
feat/allow-for-userdefined-value

Conversation

@RobPasMue

Copy link
Copy Markdown
Member

Description

Prioritize the value of env var SPACECLAIM_MODE defined by the user, to the one defined by the library.

Issue linked

Closes #1439

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue requested a review from a team as a code owner September 30, 2024 10:16
@github-actions github-actions Bot added the enhancement New features or code improvements label Sep 30, 2024
@codecov

codecov Bot commented Sep 30, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (c84a39b) to head (74d45ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ansys/geometry/core/connection/product_instance.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1440      +/-   ##
==========================================
- Coverage   91.85%   91.83%   -0.03%     
==========================================
  Files          86       86              
  Lines        6878     6880       +2     
==========================================
  Hits         6318     6318              
- Misses        560      562       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/ansys/geometry/core/connection/product_instance.py Outdated
@RobPasMue RobPasMue self-assigned this Sep 30, 2024
@RobPasMue RobPasMue merged commit 0ef4527 into main Sep 30, 2024
@RobPasMue RobPasMue deleted the feat/allow-for-userdefined-value branch September 30, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SpaceClaim is always opened in Parasolid mode.

2 participants