Skip to content

ci: update to ansys actions v8 and docs theme (static search)#1446

Merged
RobPasMue merged 5 commits into
mainfrom
ci/change-actions-to-v8
Oct 1, 2024
Merged

ci: update to ansys actions v8 and docs theme (static search)#1446
RobPasMue merged 5 commits into
mainfrom
ci/change-actions-to-v8

Conversation

@RobPasMue

@RobPasMue RobPasMue commented Oct 1, 2024

Copy link
Copy Markdown
Member

Description

Updating to actions (v8), Ansys sphinx theme to 1.1 and removing Meilisearch in favor of static search. Also putting an upper limit on protobug 5.28 due to annoying warnings.

Issue linked

None

@RobPasMue RobPasMue self-assigned this Oct 1, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner October 1, 2024 08:24
@github-actions github-actions Bot added the maintenance Package and maintenance related label Oct 1, 2024
@RobPasMue RobPasMue changed the title ci: update to ansys actions v8 ci: update to ansys actions v8 and docs theme Oct 1, 2024
@RobPasMue RobPasMue changed the title ci: update to ansys actions v8 and docs theme ci: update to ansys actions v8 and docs theme (static search) Oct 1, 2024
Comment thread pyproject.toml Outdated
@codecov

codecov Bot commented Oct 1, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (2ea5635) to head (28d56a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1446   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files          86       86           
  Lines        6880     6880           
=======================================
  Hits         6318     6318           
  Misses        562      562           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread doc/source/conf.py
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>

@SMoraisAnsys SMoraisAnsys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just wondering, what's the reason for the protobuf changes ?

@RobPasMue

RobPasMue commented Oct 1, 2024

Copy link
Copy Markdown
Member Author

LGTM Just wondering, what's the reason for the protobuf changes ?

Let me explain them later in our weekly meeting. Mostly this annoying warning that you get if you use 5.28.X and the latest grpcio-health-check versions https://github.com/ansys/pyansys-geometry/actions/runs/11119940649/job/30896029319#step:7:1777

There are issues and PRs for solving this on the grpc repo but it's very annoying and users have already complained about getting these warnings. Bottom line - it's not a PyAnsys Geometry issue, it's a dependency issue... but we are impacted.

@RobPasMue RobPasMue merged commit 4d0a554 into main Oct 1, 2024
@RobPasMue RobPasMue deleted the ci/change-actions-to-v8 branch October 1, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants