Skip to content

feat: create body from surface#1454

Merged
jonahrb merged 10 commits into
mainfrom
feat/create-surface-body
Oct 17, 2024
Merged

feat: create body from surface#1454
jonahrb merged 10 commits into
mainfrom
feat/create-surface-body

Conversation

@jonahrb

@jonahrb jonahrb commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

Description

Create surface body from surface / trimmed surface. One of the material designer requests.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Oct 7, 2024
@jonahrb jonahrb requested a review from a team as a code owner October 7, 2024 16:38
@github-actions github-actions Bot added the enhancement New features or code improvements label Oct 7, 2024
@jonahrb jonahrb changed the title create body from surface feat: create body from surface Oct 7, 2024
RobPasMue
RobPasMue previously approved these changes Oct 8, 2024

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments - LGTM!

Comment thread src/ansys/geometry/core/connection/conversions.py Outdated
Comment thread src/ansys/geometry/core/connection/conversions.py
Comment thread src/ansys/geometry/core/designer/component.py Outdated
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@codecov

codecov Bot commented Oct 14, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.90%. Comparing base (f5f4a7a) to head (4b524a2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/connection/conversions.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
+ Coverage   91.86%   91.90%   +0.04%     
==========================================
  Files          86       86              
  Lines        6930     6971      +41     
==========================================
+ Hits         6366     6407      +41     
  Misses        564      564              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically speaking - all good. However we are missing a usage example in the documentation. Can you add one?

@jonahrb jonahrb requested a review from PipKat as a code owner October 16, 2024 15:58

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge @jonahrb

@jonahrb jonahrb merged commit 052448f into main Oct 17, 2024
@jonahrb jonahrb deleted the feat/create-surface-body branch October 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants