Skip to content

fix: respect product_version when launching geometry service#1486

Merged
RobPasMue merged 4 commits into
mainfrom
fix/use_product_version_in_geometry_service_launch
Oct 17, 2024
Merged

fix: respect product_version when launching geometry service#1486
RobPasMue merged 4 commits into
mainfrom
fix/use_product_version_in_geometry_service_launch

Conversation

@greschd
Copy link
Copy Markdown
Member

@greschd greschd commented Oct 16, 2024

Description

When launching the Geometry Service with launch_modeler, respect the provided product_version keyword argument.

Issue linked

When launching with mode="geometry_service", the latest installed Ansys version was always used. Notably, also when only an older version actually has the Geometry Service installed.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@greschd greschd requested a review from a team as a code owner October 16, 2024 16:08
@greschd greschd self-assigned this Oct 16, 2024
@github-actions github-actions Bot added the bug Something isn't working label Oct 16, 2024
@greschd
Copy link
Copy Markdown
Member Author

greschd commented Oct 16, 2024

I have added appropriate unit tests.

Is there a unit test facility for checking launch modes?

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (76116c8) to head (68f82c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
+ Coverage   91.84%   91.85%   +0.01%     
==========================================
  Files          86       86              
  Lines        6928     6927       -1     
==========================================
  Hits         6363     6363              
+ Misses        565      564       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greschd greschd changed the title fix: respect product_version when launching Geometry Service fix: respect product_version when launching geometry service Oct 16, 2024
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Good catch @greschd! I thought we had changed this behavior already... my bad!

@RobPasMue
Copy link
Copy Markdown
Member

RobPasMue commented Oct 17, 2024

Is there a unit test facility for checking launch modes?

Sadly, there isn't (yet).

@RobPasMue RobPasMue merged commit 07ec973 into main Oct 17, 2024
@RobPasMue RobPasMue deleted the fix/use_product_version_in_geometry_service_launch branch October 17, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants