fix: respect product_version when launching geometry service#1486
Merged
RobPasMue merged 4 commits intoOct 17, 2024
Conversation
Member
Author
Is there a unit test facility for checking launch modes? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1486 +/- ##
==========================================
+ Coverage 91.84% 91.85% +0.01%
==========================================
Files 86 86
Lines 6928 6927 -1
==========================================
Hits 6363 6363
+ Misses 565 564 -1 ☔ View full report in Codecov by Sentry. |
Member
Sadly, there isn't (yet). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When launching the Geometry Service with
launch_modeler, respect the providedproduct_versionkeyword argument.Issue linked
When launching with
mode="geometry_service", the latest installed Ansys version was always used. Notably, also when only an older version actually has the Geometry Service installed.Checklist
feat: extrude circle to cylinder)