Skip to content

feat: performance enhancements to plotter#1496

Merged
RobPasMue merged 22 commits intomainfrom
fix/multi-colors-not-working-properly
Oct 21, 2024
Merged

feat: performance enhancements to plotter#1496
RobPasMue merged 22 commits intomainfrom
fix/multi-colors-not-working-properly

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue commented Oct 21, 2024

Description

Performance enhancements by using optimized plotter actors. Also allowing for proper multi_colors=True rendering as mentioned in #1467.

Issue linked

Closes #1467

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Oct 21, 2024
@RobPasMue
Copy link
Copy Markdown
Member Author

Testing missing - should be added shortly

@github-actions github-actions Bot added the bug Something isn't working label Oct 21, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.78%. Comparing base (bc3b1a5) to head (5cf4b10).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/plotting/plotter.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
- Coverage   91.90%   91.78%   -0.13%     
==========================================
  Files          86       86              
  Lines        6971     6974       +3     
==========================================
- Hits         6407     6401       -6     
- Misses        564      573       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions Bot added the maintenance Package and maintenance related label Oct 21, 2024
@RobPasMue RobPasMue marked this pull request as ready for review October 21, 2024 10:09
@RobPasMue RobPasMue requested review from a team and PipKat as code owners October 21, 2024 10:09
@RobPasMue RobPasMue merged commit b70e431 into main Oct 21, 2024
@RobPasMue RobPasMue deleted the fix/multi-colors-not-working-properly branch October 21, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option multi_colors incorrectly applied in PyGeometry script

2 participants