Skip to content

docs: add example file to download in the test#1501

Merged
umutsoysalansys merged 2 commits intomainfrom
docs/parameter-test-file
Oct 22, 2024
Merged

docs: add example file to download in the test#1501
umutsoysalansys merged 2 commits intomainfrom
docs/parameter-test-file

Conversation

@umutsoysalansys
Copy link
Copy Markdown
Contributor

@umutsoysalansys umutsoysalansys commented Oct 22, 2024

Description

Example file to put its URL in the example doc notebook.

Issue linked

See the main PR

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@umutsoysalansys umutsoysalansys requested a review from a team as a code owner October 22, 2024 09:33
@umutsoysalansys umutsoysalansys changed the title add example file to download in the test docadd example file to download in the test Oct 22, 2024
@umutsoysalansys umutsoysalansys changed the title docadd example file to download in the test doc: add example file to download in the test Oct 22, 2024
@umutsoysalansys umutsoysalansys changed the title doc: add example file to download in the test docs: add example file to download in the test Oct 22, 2024
RobPasMue
RobPasMue previously approved these changes Oct 22, 2024
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@umutsoysalansys umutsoysalansys self-assigned this Oct 22, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 22, 2024
@umutsoysalansys umutsoysalansys enabled auto-merge (squash) October 22, 2024 09:36
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Oct 22, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Oct 22, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (b70e431) to head (09013a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1501   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          86       86           
  Lines        6974     6974           
=======================================
  Hits         6401     6401           
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umutsoysalansys umutsoysalansys merged commit 870c744 into main Oct 22, 2024
@umutsoysalansys umutsoysalansys deleted the docs/parameter-test-file branch October 22, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants