Skip to content

feat: implement cut operation in extrude sketch#1510

Merged
RobPasMue merged 14 commits into
mainfrom
feat/extrude-sketch-cut-operation
Oct 30, 2024
Merged

feat: implement cut operation in extrude sketch#1510
RobPasMue merged 14 commits into
mainfrom
feat/extrude-sketch-cut-operation

Conversation

@RobPasMue

@RobPasMue RobPasMue commented Oct 24, 2024

Copy link
Copy Markdown
Member

Description

Provide cut argument in extrude_sketch function to allow for subtract operations.

Issue linked

Closes #1503

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Oct 24, 2024
@github-actions github-actions Bot added the enhancement New features or code improvements label Oct 24, 2024
@codecov

codecov Bot commented Oct 24, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.66%. Comparing base (8b919dd) to head (7af6f6c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/component.py 94.11% 1 Missing ⚠️
src/ansys/geometry/core/misc/measurements.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.01%     
==========================================
  Files          86       86              
  Lines        7001     7018      +17     
==========================================
+ Hits         6418     6433      +15     
- Misses        583      585       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/ansys/geometry/core/designer/component.py Outdated
Comment thread tests/integration/test_design.py Outdated
PipKat
PipKat previously approved these changes Oct 24, 2024

@PipKat PipKat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits suggested--although I see this is a draft. I only looked at it because I was copied on the PR. Sorry!

@RobPasMue

Copy link
Copy Markdown
Member Author

Minor edits suggested--although I see this is a draft. I only looked at it because I was copied on the PR. Sorry!

No problem at all - thanks @PipKat!

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@RobPasMue RobPasMue marked this pull request as ready for review October 28, 2024 09:38
@RobPasMue RobPasMue requested a review from a team as a code owner October 28, 2024 09:38
@RobPasMue RobPasMue merged commit d25808d into main Oct 30, 2024
@RobPasMue RobPasMue deleted the feat/extrude-sketch-cut-operation branch October 30, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend extrude-sketch operation to also allow for "cut" operation

3 participants