Skip to content

feat: allow for some additional extrusion direction names#1534

Merged
RobPasMue merged 2 commits into
mainfrom
feat/improve-extrude-direction-values
Nov 12, 2024
Merged

feat: allow for some additional extrusion direction names#1534
RobPasMue merged 2 commits into
mainfrom
feat/improve-extrude-direction-values

Conversation

@RobPasMue

Copy link
Copy Markdown
Member

Description

Allow for additional strings when accepting extrude directions. Makes sense to also support these...

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Nov 12, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner November 12, 2024 16:37
@github-actions github-actions Bot added the enhancement New features or code improvements label Nov 12, 2024
@codecov

codecov Bot commented Nov 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.69%. Comparing base (9cb2ac2) to head (85608dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1534   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          86       86           
  Lines        7043     7044    +1     
=======================================
+ Hits         6458     6459    +1     
  Misses        585      585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue changed the title feat: allow for some additional extrusion direction "names" feat: allow for some additional extrusion direction names Nov 12, 2024
@RobPasMue RobPasMue merged commit f6ed297 into main Nov 12, 2024
@RobPasMue RobPasMue deleted the feat/improve-extrude-direction-values branch November 12, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants