feat: adapt health check timeout algorithm#1559
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 86 86
Lines 7051 7055 +4
=======================================
+ Hits 6459 6463 +4
Misses 592 592 ☔ View full report in Codecov by Sentry. |
AlejandroFernandezLuces
left a comment
There was a problem hiding this comment.
LGTM! Just FYI, we have an exponential backoff algorithm implemented in the LLM handler. I think for this case this is enough, but in case having less connection tries is required at some point we can consider applying it here.
Noted, thanks! I don't think the exponential part is needed here. But worth keeping in mind. |
Description
As title says - timeout for health check is adapted more intelligently by backing off to double the previous timeout... until we reach the timeout limit set by the user. This allows us to adapt to "slow connections" and also avoid exposing parameters. These parameters would be hard to control by users and not expected really.
Issue linked
Closes #1558
At least the main problem in #1558 - we won't be exposing the parameter in the end.
Checklist
feat: extrude circle to cylinder)