feat: enable (partially) prepare and repair tools in Core Service#1580
Merged
RobPasMue merged 15 commits intoJan 10, 2025
Conversation
b-matteo
previously approved these changes
Dec 10, 2024
Contributor
b-matteo
left a comment
There was a problem hiding this comment.
LGTM @RobPasMue, thanks for getting that in!
Member
Author
|
Looks like that the repair tools are not ready... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
+ Coverage 91.32% 91.34% +0.02%
==========================================
Files 87 87
Lines 7133 7131 -2
==========================================
Hits 6514 6514
+ Misses 619 617 -2 ☔ View full report in Codecov by Sentry. |
MaxJPRey
previously approved these changes
Dec 13, 2024
Member
Author
Step by step 😆 there are some tests still failing, but parity is the goal! |
79cf767
RobPasMue
commented
Jan 9, 2025
RobPasMue
commented
Jan 9, 2025
RobPasMue
commented
Jan 9, 2025
RobPasMue
commented
Jan 10, 2025
RobPasMue
commented
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabling prepare and repair tools in Core Service
Issue linked
Closes #1579
Checklist
feat: extrude circle to cylinder)