Skip to content

feat: enable (partially) prepare and repair tools in Core Service#1580

Merged
RobPasMue merged 15 commits into
mainfrom
feat/enable-prepare-repair-tools-in-core-service
Jan 10, 2025
Merged

feat: enable (partially) prepare and repair tools in Core Service#1580
RobPasMue merged 15 commits into
mainfrom
feat/enable-prepare-repair-tools-in-core-service

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

Enabling prepare and repair tools in Core Service

Issue linked

Closes #1579

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Dec 10, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner December 10, 2024 16:07
@github-actions github-actions Bot added the enhancement New features or code improvements label Dec 10, 2024
b-matteo
b-matteo previously approved these changes Dec 10, 2024
Copy link
Copy Markdown
Contributor

@b-matteo b-matteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @RobPasMue, thanks for getting that in!

@RobPasMue
Copy link
Copy Markdown
Member Author

Looks like that the repair tools are not ready...

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.34%. Comparing base (6ffef87) to head (4a4f969).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/modeler.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
+ Coverage   91.32%   91.34%   +0.02%     
==========================================
  Files          87       87              
  Lines        7133     7131       -2     
==========================================
  Hits         6514     6514              
+ Misses        619      617       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MaxJPRey
MaxJPRey previously approved these changes Dec 13, 2024
Copy link
Copy Markdown
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see it supported as it can quite useful for some workflows.
Also nice to get ride of the skip linux conditions.😁

@RobPasMue
Copy link
Copy Markdown
Member Author

Nice to see it supported as it can quite useful for some workflows. Also nice to get ride of the skip linux conditions.😁

Step by step 😆 there are some tests still failing, but parity is the goal!

@pre-commit-ci pre-commit-ci Bot dismissed stale reviews from MaxJPRey and b-matteo via 79cf767 January 2, 2025 08:27
@github-actions github-actions Bot added the testing Anything related to tests label Jan 2, 2025
@github-actions github-actions Bot removed the testing Anything related to tests label Jan 9, 2025
Comment thread tests/integration/test_prepare_tools.py
Comment thread tests/integration/test_repair_tools.py
Comment thread tests/integration/test_repair_tools.py
Comment thread tests/integration/test_repair_tools.py
Comment thread tests/integration/test_repair_tools.py
Comment thread tests/integration/test_prepare_tools.py Outdated
Comment thread tests/integration/test_repair_tools.py Outdated
@RobPasMue RobPasMue changed the title feat: enable prepare and repair tools in Core Service feat: enable (partially) prepare and repair tools in Core Service Jan 9, 2025
Comment thread src/ansys/geometry/core/modeler.py
Comment thread src/ansys/geometry/core/modeler.py
@RobPasMue RobPasMue merged commit 4481063 into main Jan 10, 2025
@RobPasMue RobPasMue deleted the feat/enable-prepare-repair-tools-in-core-service branch January 10, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable tools in core services

4 participants