feat: create launcher for core services#1587
Merged
Merged
Conversation
Member
Author
|
IMPORTANT NOTE - when using
Feel free to use symbolic links to try this out. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
==========================================
- Coverage 91.61% 91.28% -0.34%
==========================================
Files 86 86
Lines 7064 7104 +40
==========================================
+ Hits 6472 6485 +13
- Misses 592 619 +27 ☔ View full report in Codecov by Sentry. |
MaxJPRey
reviewed
Dec 17, 2024
MaxJPRey
previously approved these changes
Dec 17, 2024
…ansys/pyansys-geometry into feat/launcher-for-core-services
Member
Author
|
Let's merge this one as is. Testing for launching local products is not in yet anyway (our VMs rely on Docker). We can come back to fix things. |
b-matteo
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a launching mechanism for Core Services. Should work both on Windows and Linux
Issue linked
Closes #1578
Checklist
feat: extrude circle to cylinder)