Skip to content

feat: create a fillet on an edge/face#1621

Merged
jonahrb merged 23 commits into
blitzfrom
feat/fillet
Jan 13, 2025
Merged

feat: create a fillet on an edge/face#1621
jonahrb merged 23 commits into
blitzfrom
feat/fillet

Conversation

@jonahrb
Copy link
Copy Markdown
Contributor

@jonahrb jonahrb commented Jan 10, 2025

Description

Add the fillet command, which provides the ability to create a fillet on an edge or adjust the existing fillet of a face.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb requested a review from a team as a code owner January 10, 2025 19:27
@jonahrb jonahrb changed the title Feat/fillet feat: create a fillet on an edge/face Jan 10, 2025
@jonahrb jonahrb self-assigned this Jan 10, 2025
@github-actions github-actions Bot added maintenance Package and maintenance related enhancement New features or code improvements labels Jan 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (4f74754) to head (8a3a9e2).
Report is 1 commits behind head on blitz.

Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1621      +/-   ##
==========================================
+ Coverage   91.34%   91.36%   +0.01%     
==========================================
  Files          87       87              
  Lines        7131     7147      +16     
==========================================
+ Hits         6514     6530      +16     
  Misses        617      617              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some small comments

Comment thread src/ansys/geometry/core/designer/geometry_commands.py
Comment thread doc/changelog.d/1620.added.md Outdated
@github-actions github-actions Bot removed the maintenance Package and maintenance related label Jan 13, 2025
@RobPasMue
Copy link
Copy Markdown
Member

Looks like the Linux version requires an update - ping @b-matteo

@jonahrb
Copy link
Copy Markdown
Contributor Author

jonahrb commented Jan 13, 2025

Looks like the Linux version requires an update - ping @b-matteo

@RobPasMue the linux is python error though, I'm confused why it didn't fail on other backends

@jonahrb
Copy link
Copy Markdown
Contributor Author

jonahrb commented Jan 13, 2025

@RobPasMue looks like i can just bump unstable to stable though and ignore those, what do you think

@jonahrb
Copy link
Copy Markdown
Contributor Author

jonahrb commented Jan 13, 2025

nevermind - i see on blitz we are skipping testing for unstable containers

@jonahrb jonahrb merged commit e4955c0 into blitz Jan 13, 2025
@jonahrb jonahrb deleted the feat/fillet branch January 13, 2025 14:02
RobPasMue added a commit that referenced this pull request Jan 20, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants