feat: create a fillet on an edge/face#1621
Merged
Merged
Conversation
… into feat/fillet
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## blitz #1621 +/- ##
==========================================
+ Coverage 91.34% 91.36% +0.01%
==========================================
Files 87 87
Lines 7131 7147 +16
==========================================
+ Hits 6514 6530 +16
Misses 617 617 ☔ View full report in Codecov by Sentry. |
RobPasMue
approved these changes
Jan 13, 2025
Member
|
Looks like the Linux version requires an update - ping @b-matteo |
Contributor
Author
@RobPasMue the linux is python error though, I'm confused why it didn't fail on other backends |
Contributor
Author
|
@RobPasMue looks like i can just bump unstable to stable though and ignore those, what do you think |
Contributor
Author
|
nevermind - i see on blitz we are skipping testing for unstable containers |
RobPasMue
added a commit
that referenced
this pull request
Jan 20, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the fillet command, which provides the ability to create a fillet on an edge or adjust the existing fillet of a face.
Issue linked
Checklist
feat: extrude circle to cylinder)