Skip to content

feat: extrude existing faces, setup face offset relationships#1628

Merged
jonahrb merged 7 commits intoblitzfrom
feat/extrude-and-offset-faces
Jan 14, 2025
Merged

feat: extrude existing faces, setup face offset relationships#1628
jonahrb merged 7 commits intoblitzfrom
feat/extrude-and-offset-faces

Conversation

@jonahrb
Copy link
Copy Markdown
Contributor

@jonahrb jonahrb commented Jan 13, 2025

Description

Extrude existing faces, extrude faces up to other objects, setup face offset relationships between two faces.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Jan 13, 2025
@jonahrb jonahrb requested a review from a team as a code owner January 13, 2025 19:30
@github-actions github-actions bot added the enhancement New features or code improvements label Jan 13, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.38%. Comparing base (e79ef3b) to head (9843567).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
.../ansys/geometry/core/designer/geometry_commands.py 92.30% 4 Missing ⚠️
src/ansys/geometry/core/designer/body.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            blitz    #1628   +/-   ##
=======================================
  Coverage   91.37%   91.38%           
=======================================
  Files          87       87           
  Lines        7156     7219   +63     
=======================================
+ Hits         6539     6597   +58     
- Misses        617      622    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue
Copy link
Copy Markdown
Member

Feel free to merge whenever you think it-s ready @jonahrb

@jonahrb jonahrb merged commit 5201f65 into blitz Jan 14, 2025
@jonahrb jonahrb deleted the feat/extrude-and-offset-faces branch January 14, 2025 16:03
RobPasMue pushed a commit that referenced this pull request Jan 20, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants