Conversation
The interference tool was exposed in the API server but not in python. One thing to notice is that this tool doesn't do tracking so the fix method will fail with the current API server. A pending PR is adding a try catch to allow lack of tracking to throw an exception.
RobPasMue
left a comment
There was a problem hiding this comment.
Left some comments @smereu - some of them are suggestions which you can directly commit through the GitHub Web interface and then pull on your local branch. Other changes will require yourself to handle them. Feel free to ping me if you need any support!
Leaving as Request changes until comments are solved
|
Also - PyAnsys Geometry uses conventional commit styling for its PR names. You can see that this CI/CD stage failed here: https://github.com/ansys/pyansys-geometry/actions/runs/12779177188/job/35623345385?pr=1633 If you change the name of your PR accordingly, it should pass. For example, since this is a feature, it makes sense that the name of the PR is |
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
|
@RobPasMue Thanks for the review Roberto and apologies for silly mistakes :-). If there is anything outstanding, please drop me a note |
Respond to code review
RobPasMue
left a comment
There was a problem hiding this comment.
2 small extra comments - related to protect_grpc. Once that's solved, this PR is ready to merge =)
…sys-geometry into feat/fix_interference
Apply format
…sys-geometry into feat/fix_interference
Add one more protect_grpc
|
@RobPasMue The test for fix interference should pass with the latest build but I still see it failing. Is there something I can do to check? Any other comment to be resolved? |
|
Hi @smereu - I had to implement commit fc3b578 otherwise the check_type method couldn't run since it had no idea about what a Body object is (it was only being imported for type hint purposes). Anyway, it looks like your tests are failing against Core Service... and my knowledge on that area is limited. Until it is fixed on the service or on the test itself, we can't merge it. |
…sys-geometry into feat/fix_interference
Description
This PR adds the the interference tool that was implemented in the API server but not in the python layer. One thing to notice is that this tool doesn't do tracking so the fix method will fail with the current API server. A pending API server PR is adding a try catch to allow lack of tracking to throw an exception.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)