feat: parameters refurbished#1647
Merged
Merged
Conversation
…ansys-geometry into feat/driving-dimensions
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
…ansys-geometry into feat/driving-dimensions
PipKat
reviewed
Jan 20, 2025
PipKat
reviewed
Jan 20, 2025
PipKat
reviewed
Jan 20, 2025
PipKat
reviewed
Jan 20, 2025
PipKat
reviewed
Jan 20, 2025
PipKat
reviewed
Jan 20, 2025
PipKat
reviewed
Jan 20, 2025
PipKat
approved these changes
Jan 20, 2025
Member
There was a problem hiding this comment.
Performed doc review. @umutsoysalansys Is PR #1340 just an earlier (obsolete) version of this PR? I'm a bit confused, but I don't think I need to review PR #1340 too. Am I correct?
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Contributor
Author
|
@RobPasMue @jrwest440 @smereu please note that I also had to add a method to modeler to close existing designs. CoreService backend doesn't really support having multiple designs and pytest suit we use here is opening many designs without closing them after each test resulting the error in the SC method that is being used in the backend for this feature. |
Contributor
Author
|
@PipKat You are correct, this one is based on the old one and currently merged now while the old is closed. Thanks for your review! Appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parameters branch republished within blitz branch as requested.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)