feat: rename object#1648
Merged
Merged
Conversation
…o feat/jacob_rename_object # Conflicts: # src/ansys/geometry/core/designer/geometry_commands.py # tests/integration/test_geometry_commands.py
RobPasMue
requested changes
Jan 17, 2025
fixed input to take list[str]
…yansys-geometry into feat/jacob_rename_object # Conflicts: # src/ansys/geometry/core/designer/geometry_commands.py # tests/integration/test_geometry_commands.py
…o feat/jacob_rename_object
…yansys-geometry into feat/jacob_rename_object
…o feat/jacob_rename_object
…yansys-geometry into feat/jacob_rename_object
RobPasMue
requested changes
Jan 20, 2025
RobPasMue
reviewed
Jan 20, 2025
RobPasMue
reviewed
Jan 20, 2025
RobPasMue
reviewed
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented the call to rename object and added the appropriate unit test
Reinstated the _clear_cached_bodies method to keep client and server in sync
Issue linked
Checklist
feat: extrude circle to cylinder)