Conversation
wrote unit tests to verify
RobPasMue
previously requested changes
Jan 21, 2025
Member
|
@jacobrkerstetter - please modify the PR description according to the guidelines whenever you get the chance. This allows us to properly maintain the repository and easily determine features and implementations |
jonahrb
approved these changes
Jan 21, 2025
RobPasMue
reviewed
Jan 22, 2025
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
@jacobrkerstetter - please fix my request in you upcoming PR
Comment on lines
+512
to
+513
| class UnsimplifiedFaceProblemAreas(ProblemArea): | ||
| """Represents a unsimplified face problem area with unique identifier and associated faces.""" |
Member
There was a problem hiding this comment.
Docstring is not properly formatted. This has to be solved.
Member
There was a problem hiding this comment.
You are missing all the class constructor input parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements and tests the FindSimplify and FixSimplify commands for pygeometry.
Issue linked
Checklist
feat: extrude circle to cylinder)