Merged
Conversation
Member
|
Hi @david-gorman - could you solve the existing conflicts between your branch and the blitz branch? I will start reviewing nonetheless :) |
RobPasMue
approved these changes
Jan 22, 2025
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Apart from my comments - LGTM @david-gorman - thanks for the implementation!
# Conflicts: # src/ansys/geometry/core/designer/geometry_commands.py # tests/integration/test_geometry_commands.py
RobPasMue
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added functionality to split body by planes, splitters, or faces.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)