Skip to content

feat: implementation of NURBS curves#1675

Merged
RobPasMue merged 5 commits intoblitzfrom
feat/nurbs-curve-implementation
Jan 27, 2025
Merged

feat: implementation of NURBS curves#1675
RobPasMue merged 5 commits intoblitzfrom
feat/nurbs-curve-implementation

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

Implementation of NURBS-based curves on Python side.

Issue linked

Closes #46

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jan 22, 2025
@RobPasMue
Copy link
Copy Markdown
Member Author

We are still pending to make the link with the server side, for extrusion paths for example... requires syncing with @mlkaplan36

@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to tests enhancement New features or code improvements labels Jan 22, 2025
@RobPasMue
Copy link
Copy Markdown
Member Author

Link between client and server will be done later. Partially closing #46 consequently

@RobPasMue RobPasMue marked this pull request as ready for review January 24, 2025 14:30
@RobPasMue RobPasMue requested a review from a team as a code owner January 24, 2025 14:30
@RobPasMue RobPasMue enabled auto-merge (squash) January 27, 2025 07:16
@RobPasMue RobPasMue merged commit f746d51 into blitz Jan 27, 2025
@RobPasMue RobPasMue deleted the feat/nurbs-curve-implementation branch January 27, 2025 07:43
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 90.80460% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.42%. Comparing base (f5e93d6) to head (c257154).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
src/ansys/geometry/core/shapes/curves/nurbs.py 90.58% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            blitz    #1675   +/-   ##
=======================================
  Coverage   91.41%   91.42%           
=======================================
  Files          90       91    +1     
  Lines        7759     7846   +87     
=======================================
+ Hits         7093     7173   +80     
- Misses        666      673    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants