Skip to content

ci: ensure design is closed on test exit#1680

Merged
RobPasMue merged 4 commits intoblitzfrom
feat/test-cleanup-on-exit
Jan 23, 2025
Merged

ci: ensure design is closed on test exit#1680
RobPasMue merged 4 commits intoblitzfrom
feat/test-cleanup-on-exit

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue commented Jan 23, 2025

Description

Ensure design closure on each test ending.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jan 23, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner January 23, 2025 14:11
@github-actions github-actions bot added the enhancement New features or code improvements label Jan 23, 2025
Copy link
Copy Markdown
Contributor

@b-matteo b-matteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way better. Thanks @RobPasMue

@RobPasMue RobPasMue enabled auto-merge (squash) January 23, 2025 14:32
@RobPasMue RobPasMue merged commit 546c73b into blitz Jan 23, 2025
@RobPasMue RobPasMue deleted the feat/test-cleanup-on-exit branch January 23, 2025 14:39
Copy link
Copy Markdown
Contributor

@umutsoysalansys umutsoysalansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobPasMue good work @b-matteo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants