Skip to content

feat: get assigned material - #1684

Merged
jacobrkerstetter merged 7 commits into
blitzfrom
feat/get_assigned_material
Jan 24, 2025
Merged

feat: get assigned material#1684
jacobrkerstetter merged 7 commits into
blitzfrom
feat/get_assigned_material

Conversation

@jacobrkerstetter

@jacobrkerstetter jacobrkerstetter commented Jan 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds the ability to get the material assigned to a body
Adds conversion methods for gRPC Materials and Material Properties

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter
added ability to get material from body
b3ba929 
added conversion from grpc_material to material
@jacobrkerstetter jacobrkerstetter self-assigned this Jan 23, 2025
@jacobrkerstetter
jacobrkerstetter requested a review from a team as a code owner January 23, 2025 20:28
@github-actions github-actions Bot added the enhancement New features or code improvements label Jan 23, 2025
RobPasMue
RobPasMue approved these changes Jan 24, 2025
View reviewed changes

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments - but LGTM!! Thanks @jacobrkerstetter for this implementation

Comment thread src/ansys/geometry/core/designer/body.py Outdated
Comment thread src/ansys/geometry/core/connection/conversions.py Outdated
@jacobrkerstetter
jacobrkerstetter enabled auto-merge (squash) January 24, 2025 13:03
@jacobrkerstetter
jacobrkerstetter merged commit 2f32019 into blitz Jan 24, 2025
@jacobrkerstetter
jacobrkerstetter deleted the feat/get_assigned_material branch January 24, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@jacobrkerstetter jacobrkerstetter

Labels

enhancement New features or code improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobrkerstetter @RobPasMue @pyansys-ci-bot