Skip to content

fix: filter set export id to only CoreService based backends#1685

Merged
b-matteo merged 3 commits into
blitzfrom
fix/test_open_file_filtering_stride
Jan 24, 2025
Merged

fix: filter set export id to only CoreService based backends#1685
b-matteo merged 3 commits into
blitzfrom
fix/test_open_file_filtering_stride

Conversation

@b-matteo
Copy link
Copy Markdown
Contributor

Description

This change is to fix the test_open_file. We used to call set and get export id for whatever backend type we where testing against. Right now those apis are only implemented in CoreService based backends, so we should only use set and get export id against those.

Checklist

  • I have tested my changes locally.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@b-matteo b-matteo added bug Something isn't working testing Anything related to tests labels Jan 24, 2025
@b-matteo b-matteo self-assigned this Jan 24, 2025
@b-matteo b-matteo requested a review from a team as a code owner January 24, 2025 09:58
@github-actions github-actions Bot removed the testing Anything related to tests label Jan 24, 2025
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@b-matteo b-matteo merged commit d520914 into blitz Jan 24, 2025
@b-matteo b-matteo deleted the fix/test_open_file_filtering_stride branch January 24, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants