Skip to content

fix: cleanup unsupported module#1690

Merged
RobPasMue merged 4 commits intoblitzfrom
fix/cleanup-unsupported
Jan 27, 2025
Merged

fix: cleanup unsupported module#1690
RobPasMue merged 4 commits intoblitzfrom
fix/cleanup-unsupported

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

Relocate and clean unsupported module

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jan 27, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner January 27, 2025 09:00
@github-actions github-actions bot added the bug Something isn't working label Jan 27, 2025
Copy link
Copy Markdown
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.43%. Comparing base (f746d51) to head (4bfb48d).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
src/ansys/geometry/core/tools/unsupported.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1690      +/-   ##
==========================================
+ Coverage   91.42%   91.43%   +0.01%     
==========================================
  Files          91       91              
  Lines        7846     7847       +1     
==========================================
+ Hits         7173     7175       +2     
+ Misses        673      672       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 9105449 into blitz Jan 27, 2025
@RobPasMue RobPasMue deleted the fix/cleanup-unsupported branch January 27, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants