feat: export and download stride format#1698
Merged
Merged
Conversation
Implementing two additional backend types: CORE_WINDOWS and CORE_LINUX Add export to disco format Add export to stride format Refactor download method to only consume one kind of grpc call Add test for stride export Add test for disco export
…ansys-geometry into fix/import_body_locally
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## blitz #1698 +/- ##
==========================================
- Coverage 91.33% 91.17% -0.16%
==========================================
Files 91 91
Lines 7892 7924 +32
==========================================
+ Hits 7208 7225 +17
- Misses 684 699 +15 ☔ View full report in Codecov by Sentry. |
RobPasMue
reviewed
Jan 28, 2025
RobPasMue
reviewed
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the STRIDE format export and download in PyAnsys Geometry. Furthermore the design.download method now uses a more straightforward implementation, still allowing previous backend export and download workflows.
Checklist
feat: extrude circle to cylinder)