feat: blitz development by RobPasMue · Pull Request #1701 · ansys/pyansys-geometry

RobPasMue · 2025-01-29T07:07:58Z

Main blitz developments merge into the main branch. Pending full review.

…o blitz

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: jonahrb <jonahboling@gmail.com> Co-authored-by: Jonah Boling <56607167+jonahrb@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: jonahrb <jonahboling@gmail.com> Co-authored-by: Jonah Boling <56607167+jonahrb@users.noreply.github.com>

…o blitz

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: jkerstet <jacob.kerstetter@ansys.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: jkerstet <jacob.kerstetter@ansys.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Co-authored-by: Michael Janes <mikedjanes@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

…ix (#1666) Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Co-authored-by: Mike Kaplan <michael.kaplan@ansys.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: rward <ryan.ward@ansys.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

codecov · 2025-01-29T07:26:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (c5d5426) to head (4044462).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
- Coverage   91.37%   91.02%   -0.35%     
==========================================
  Files          87       91       +4     
  Lines        7143     8004     +861     
==========================================
+ Hits         6527     7286     +759     
- Misses        616      718     +102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RobPasMue

Overall the blitz branch is in good shape, most of the suggestions are format based, import based or docstring based. Let's get it wrapped up. Working on my side to resolve the comments. Any other reviews are appreciated!

b-matteo

Several docstrings missing but above all, some security decorators missing

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

b-matteo

LGTM! Thanks @RobPasMue for taking care of the feedbacks

…o blitz

RobPasMue and others added 30 commits January 10, 2025 11:37

ci: simplify ci for blitz

ed028b0

ci: simplify ci for blitz

54f3b60

Merge branch 'blitz' of https://github.com/ansys/pyansys-geometry int…

4f74754

…o blitz

feat: create a fillet on an edge/face (#1621)

e4955c0

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

feat: create a full fillet between multiple faces (#1623)

e79ef3b

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

feat: extrude existing faces, setup face offset relationships (#1628)

5201f65

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

feat: extrude existing edges to create surface bodies (#1638)

6b57225

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

build: bump ansys-api-geometry in blitz branch

0b26b26

build: using ansys-api-geometry 0.4.29

72049ba

build: bump ansys-api-geometry in blitz branch

7c25285

feat: create and modify linear patterns (#1641)

6315fa1

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

feat: body suppression state (#1643)

51b8797

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

feat: surface body from trimmed curves (#1650)

b20f1c7

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

ci: simplify ci for blitz

c917586

feat: create a fillet on an edge/face (#1621)

4b71674

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

feat: create a full fillet between multiple faces (#1623)

4add452

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

feat: extrude existing faces, setup face offset relationships (#1628)

17454c9

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

feat: extrude existing edges to create surface bodies (#1638)

e89d79d

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

feat: create and modify linear patterns (#1641)

b700d7f

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

feat: body suppression state (#1643)

6f84751

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

feat: surface body from trimmed curves (#1650)

e429375

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Merge branch 'blitz' of https://github.com/ansys/pyansys-geometry int…

b55f379

…o blitz

feat: create circular and fill patterns (#1653)

0ebf4b2

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

feat: revolve faces a set distance, up to another object, or by a hel…

89382c9

…ix (#1666) Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

umutsoysalansys and others added 6 commits January 28, 2025 08:26

feat: matrix rotation and translation (#1689)

ab39ca0

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Merge branch 'main' into blitz

bb11e2f

fix: issues with tests

1bb39e5

ci: revert workflow modifications

5524957

RobPasMue self-assigned this Jan 29, 2025

Merge branch 'main' into blitz

aaa41a9

github-actions Bot added maintenance Package and maintenance related testing Anything related to tests labels Jan 29, 2025

chore: adding changelog file 1701.added.md [dependabot-skip]

6b1622a

RobPasMue commented Jan 29, 2025

View reviewed changes

b-matteo reviewed Jan 29, 2025

View reviewed changes

RobPasMue and others added 2 commits January 29, 2025 15:06

fix: tech review fixes for blitz branch (#1703)

4a9dc2d

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

fix: url build for assets

f256eea

RobPasMue marked this pull request as ready for review January 29, 2025 15:08

RobPasMue requested review from a team and PipKat as code owners January 29, 2025 15:08

Merge branch 'main' into blitz

fccaa24

b-matteo previously approved these changes Jan 29, 2025

View reviewed changes

jonahrb reviewed Jan 29, 2025

View reviewed changes

Comment thread doc/source/examples/03_modeling/design_parameters.mystnb

RobPasMue added 2 commits January 29, 2025 16:25

fix: ref to read_existing_design in docs

4041bd4

Merge branch 'blitz' of https://github.com/ansys/pyansys-geometry int…

4044462

…o blitz

RobPasMue dismissed b-matteo’s stale review via 4044462 January 29, 2025 15:25

jonahrb approved these changes Jan 29, 2025

View reviewed changes

RobPasMue enabled auto-merge (squash) January 29, 2025 15:50

RobPasMue merged commit 695b425 into main Jan 29, 2025

RobPasMue deleted the blitz branch January 29, 2025 15:56

RobPasMue mentioned this pull request Jan 30, 2025

feat: add contributors #1708

Merged

Conversation

RobPasMue commented Jan 29, 2025

Uh oh!

codecov Bot commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

RobPasMue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

b-matteo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

b-matteo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

codecov Bot commented Jan 29, 2025 •

edited

Loading