Skip to content

feat: design activation changes#1707

Merged
jacobrkerstetter merged 4 commits into
mainfrom
feat/design_activation
Jan 30, 2025
Merged

feat: design activation changes#1707
jacobrkerstetter merged 4 commits into
mainfrom
feat/design_activation

Conversation

@jacobrkerstetter

@jacobrkerstetter jacobrkerstetter commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

Description

  • Removed temporary design in insert_file to avoid multiple designs being active at once
  • Activated tests to verify design is active

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

…ng active at once

activated tests to verify design is active
@jacobrkerstetter jacobrkerstetter self-assigned this Jan 29, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner January 29, 2025 16:32
@github-actions github-actions Bot added the enhancement New features or code improvements label Jan 29, 2025
@codecov

codecov Bot commented Jan 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (695b425) to head (4a0b39c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1707   +/-   ##
=======================================
  Coverage   91.02%   91.03%           
=======================================
  Files          91       91           
  Lines        8004     7995    -9     
=======================================
- Hits         7286     7278    -8     
+ Misses        718      717    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) January 29, 2025 19:07

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jacobrkerstetter !

@jacobrkerstetter jacobrkerstetter merged commit c9d691f into main Jan 30, 2025
@jacobrkerstetter jacobrkerstetter deleted the feat/design_activation branch January 30, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants