feat: Implementation of inspect & repair geometry - #1712
Merged
Conversation
Implementation of inspect & repair geometry. Face and Edges are returned from message but they are reported only as ids because attempt to retrieve them causes circular dependencies and other issues with importing modules
smereu
requested review from
RobPasMue,
b-matteo,
jonahrb and
umutsoysalansys
January 31, 2025 17:42
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1712 +/- ##
==========================================
+ Coverage 90.80% 90.81% +0.01%
==========================================
Files 91 92 +1
Lines 8003 8080 +77
==========================================
+ Hits 7267 7338 +71
- Misses 736 742 +6 ☔ View full report in Codecov by Sentry. |
…s/pyansys-geometry into feat/inspect_repair_results
clean-up & add test
fix for pre-commit check
…s/pyansys-geometry into feat/inspect_repair_results
smereu
marked this pull request as ready for review
February 5, 2025 05:26
Contributor
Author
|
If needed we can add actual face object to the result of the inspect method but for now there is no use for it so we can just report the ids |
Member
|
Let me pull your branch and do some local refactoring if you don't mind @smereu |
MaxJPRey
reviewed
Feb 5, 2025
1) use grpc_id 2) Enum vs string 3) Make bodies optional argument for inspect and repair 4) Remove strings for some argument 5) Remove unused variable
change to adjust to core services order
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
…s/pyansys-geometry into feat/inspect_repair_results
RobPasMue
previously approved these changes
Feb 11, 2025
jrwest440
previously approved these changes
Feb 12, 2025
RobPasMue
approved these changes
Feb 13, 2025
RobPasMue
enabled auto-merge (squash)
February 13, 2025 07:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation of inspect & repair geometry.
The branch needs the latest version of the protos from the API server
Face and Edges are returned from message but they are reported only as ids because attempt to retrieve them causes circular dependencies and other issues with importing modules
The script below can be used to test the code
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)