Skip to content

test: Expand pattern tests#1713

Merged
RobPasMue merged 10 commits into
mainfrom
test/more_pattern_tests
Feb 6, 2025
Merged

test: Expand pattern tests#1713
RobPasMue merged 10 commits into
mainfrom
test/more_pattern_tests

Conversation

@RyanJWard

@RyanJWard RyanJWard commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

Description

Expand pattern tests

Checklist

  • I have tested my changes locally.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard requested a review from a team as a code owner January 31, 2025 20:03
@RyanJWard RyanJWard self-assigned this Jan 31, 2025
@RyanJWard RyanJWard changed the title Expand pattern tests tests: Expand pattern tests Jan 31, 2025
@RyanJWard RyanJWard changed the title tests: Expand pattern tests test: Expand pattern tests Jan 31, 2025
@RyanJWard

Copy link
Copy Markdown
Contributor Author

Modifying the linear pattern is failing with DMS. I will need to check my DMS script console to see if this is an issue with DMS

RobPasMue
RobPasMue previously approved these changes Feb 4, 2025

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment that applies to all tests. Apart from that LGTM!

Comment thread tests/integration/test_geometry_commands.py
@codecov

codecov Bot commented Feb 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (26182e3) to head (46fb148).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1713   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          91       91           
  Lines        8006     8006           
=======================================
  Hits         7281     7281           
  Misses        725      725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue merged commit 1810ed0 into main Feb 6, 2025
@RobPasMue RobPasMue deleted the test/more_pattern_tests branch February 6, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants