Skip to content

fix: support body mirror on linux#1714

Merged
jonahrb merged 2 commits into
mainfrom
fix/body-mirror-linux
Feb 3, 2025
Merged

fix: support body mirror on linux#1714
jonahrb merged 2 commits into
mainfrom
fix/body-mirror-linux

Conversation

@jonahrb

@jonahrb jonahrb commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

Description

I added support on CoreService, so the test skip can be removed now.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Jan 31, 2025
@jonahrb jonahrb requested a review from a team as a code owner January 31, 2025 23:16
@github-actions github-actions Bot added the bug Something isn't working label Jan 31, 2025
@jonahrb

jonahrb commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

CoreService Linux works, but CoreService Windows image will likely fail - just need to generate a new one from ApiServer

@codecov

codecov Bot commented Jan 31, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (ca38489) to head (7447885).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1714   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files          91       91           
  Lines        7995     7995           
=======================================
  Hits         7278     7278           
  Misses        717      717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxJPRey MaxJPRey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jonahrb jonahrb enabled auto-merge (squash) February 3, 2025 13:59

@b-matteo b-matteo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahrb jonahrb merged commit 6d1d74e into main Feb 3, 2025
@jonahrb jonahrb deleted the fix/body-mirror-linux branch February 3, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants