Conversation
|
@RobPasMue i will defer to you here. I have no experience with the launcher code so i just did what was minimally invasive and functional. |
…nsys-geometry into feat/launch-from-envar
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1716 +/- ##
==========================================
- Coverage 91.03% 90.94% -0.09%
==========================================
Files 91 91
Lines 7995 8006 +11
==========================================
+ Hits 7278 7281 +3
- Misses 717 725 +8 ☔ View full report in Codecov by Sentry. |
RobPasMue
left a comment
There was a problem hiding this comment.
Implementation looks good but we should document this somewhere - probably in the docs page where we are showing how to launch the services. Would you mind adding it there @jonahrb? Apart from that, all good - I'll approve once the docs are up.
|
Need to do a local mod... I'll ping you asap |
Description
Allow the option to define ANSYS_GEOMETRY_SERVICE_ROOT envar to provide path to CoreService executable instead of assuming the unified install.
Issue linked
Checklist
feat: extrude circle to cylinder)