Skip to content

fix: revert boolean ops logic and hold-off on commands-based implementation (temporarily)#1725

Merged
RobPasMue merged 12 commits into
mainfrom
fix/test-intersect-failure
Feb 11, 2025
Merged

fix: revert boolean ops logic and hold-off on commands-based implementation (temporarily)#1725
RobPasMue merged 12 commits into
mainfrom
fix/test-intersect-failure

Conversation

@RobPasMue

Copy link
Copy Markdown
Member

Description

Coming from #1724

Issue linked

Closes #1724

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Feb 5, 2025
@github-actions github-actions Bot added the bug Something isn't working label Feb 5, 2025
@RobPasMue RobPasMue marked this pull request as ready for review February 7, 2025 16:11
@RobPasMue RobPasMue requested a review from a team as a code owner February 7, 2025 16:11
@RobPasMue RobPasMue changed the title fix: verify intersect failure has been solved fix: revert boolean ops logic and hold-off on commands-based implementation (temporarily) Feb 7, 2025
@codecov

codecov Bot commented Feb 7, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (b39ac30) to head (dc0ebe0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1725      +/-   ##
==========================================
- Coverage   90.94%   90.75%   -0.19%     
==========================================
  Files          91       91              
  Lines        8006     8007       +1     
==========================================
- Hits         7281     7267      -14     
- Misses        725      740      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxJPRey MaxJPRey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RobPasMue RobPasMue enabled auto-merge (squash) February 11, 2025 15:51
@RobPasMue RobPasMue merged commit 3173492 into main Feb 11, 2025
@RobPasMue RobPasMue deleted the fix/test-intersect-failure branch February 11, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boolean Intersection not working in all cases

4 participants