Skip to content

test: set body name#1727

Merged
jacobrkerstetter merged 6 commits into
mainfrom
feat/set_body_name
Feb 7, 2025
Merged

test: set body name#1727
jacobrkerstetter merged 6 commits into
mainfrom
feat/set_body_name

Conversation

@jacobrkerstetter

@jacobrkerstetter jacobrkerstetter commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

Description

Activating set body name test for CoreService (already was activated for DMS and Linux)

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Feb 5, 2025
@jacobrkerstetter
jacobrkerstetter requested a review from a team as a code owner February 5, 2025 19:59
@github-actions github-actions Bot added the enhancement New features or code improvements label Feb 5, 2025
@jacobrkerstetter
jacobrkerstetter enabled auto-merge (squash) February 5, 2025 20:01
@codecov

codecov Bot commented Feb 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (3a3b2a6) to head (1866213).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1727   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          91       91           
  Lines        8006     8006           
=======================================
  Hits         7281     7281           
  Misses        725      725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue

Copy link
Copy Markdown
Member

Looks like it is still failing @jacobrkerstetter :S

@jacobrkerstetter

Copy link
Copy Markdown
Contributor Author

@RobPasMue it needs the ApiServer updates from yesterday -- do these automatically come daily?

@RobPasMue

Copy link
Copy Markdown
Member

@RobPasMue it needs the ApiServer updates from yesterday -- do these automatically come daily?

They should yeah - @b-matteo ?

@jrwest440

Copy link
Copy Markdown

@RobPasMue it needs the ApiServer updates from yesterday -- do these automatically come daily?

They should yeah - @b-matteo ?

We were seeing issues with the posted Artifactory packages. They had Core Service content that was not up-to-date. Yesterday had a 1/31 copy. So I believe Ryan and Matteo are still trying to iron that out - because the nuget pull is saying its pulling the latest.

@jacobrkerstetter
jacobrkerstetter merged commit 70b893c into main Feb 7, 2025
@jacobrkerstetter
jacobrkerstetter deleted the feat/set_body_name branch February 7, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants