feat: add face color, round info, bring measure tools to linux#1732
Merged
Conversation
- get round info + test - get closest separation (body to body) + test
- wip design insert file with body names
- face get color efficiency fix - body export_gltf for exporting single bodies
github-actions
Bot
added
testing
RobPasMue
requested changes
Feb 7, 2025
… feat/workflow_10_additions
- activated MeasurementTools for CoreService - refactored intersecting bounding boxes to meet standards - abstracted color conversion to hex to auxiliary method - added tests for all features
…/pyansys-geometry into feat/workflow_10_additions
Member
|
@jacobrkerstetter - can we improve the title of the PR? I know it makes sense for you (us) since we know what workflow 10 stands for but let's assign it a more feature-oriented name if possible =) |
jacobrkerstetter
changed the title
jonahrb
reviewed
Feb 12, 2025
jonahrb
changed the title
jrwest440
reviewed
Feb 12, 2025
jrwest440
previously approved these changes
Feb 12, 2025
RobPasMue
reviewed
Feb 13, 2025
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
@jacobrkerstetter - left some comments, the PR is in a very good state, they are mostly minor modifications. Thanks for all the work! Once the requests go in, I will approve and merge =)
… feat/workflow_10_additions # Conflicts: # src/ansys/geometry/core/modeler.py
…/pyansys-geometry into feat/workflow_10_additions
RobPasMue
reviewed
Feb 13, 2025
…/pyansys-geometry into feat/workflow_10_additions
RobPasMue
approved these changes
Feb 13, 2025
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for this contribution!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1732 +/- ##
==========================================
+ Coverage 90.81% 90.84% +0.03%
==========================================
Files 92 92
Lines 8080 8152 +72
==========================================
+ Hits 7338 7406 +68
- Misses 742 746 +4 ☔ View full report in Codecov by Sentry. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding various features needed for workflow 10. Includes Face RoundInfo, Face/Body ClosestSeparation, and Face Colors.
Issue linked
Checklist
feat: extrude circle to cylinder)